defense-in-depth check for <Error> in CompleteMultipartUpload respons…#622
Open
cloud4t0r wants to merge 1 commit into
Open
defense-in-depth check for <Error> in CompleteMultipartUpload respons…#622cloud4t0r wants to merge 1 commit into
cloud4t0r wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
The issue stems from a documented edge case by AWS: when you perform a CompleteMultipartUpload, S3 may return an HTTP 200 OK with an XML body containing an instead of the expected . This typically occurs during internal S3 overloads (InternalError). Without this patch, the SDK treated the 200 as a success and continued, even though the multipart upload had actually failed.
this patch address this todo in the original code :
/**
* TODO: The body of the response can be ERROR, check Error specified in body part from
* https://docs.aws.amazon.com/AmazonS3/latest/API/API_CompleteMultipartUpload.html#AmazonS3-CompleteMultipartUpload-response-CompleteMultipartUploadOutput
* We need to handle this case.
* TODO: the checksum returned within the response of complete multipart upload need to be exposed?
*/
Description of changes:
The patch adds three protections in the AWS_S3_AUTO_RANGED_PUT_REQUEST_TAG_COMPLETE_MULTIPART_UPLOAD handler:
In summary: this is defense‑in‑depth so that the calling code never treats a multipart upload as successful if S3 has returned an error disguised as a 200 OK.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.